percyqaz / UltimateInventory

Minecraft server plugin to streamline inventory management - Supports PaperMC and SpigotMC
https://www.spigotmc.org/resources/ultimate-inventory-1-19-1-20.109298/
MIT License
9 stars 2 forks source link

Support opening enchanting tables from the inventory #4

Open percyqaz opened 1 year ago

percyqaz commented 1 year ago

This would be a new feature that can work on both Spigot and PaperMC

Original considerations from #3:

@percyqaz:

Enchanting tables need bookshelves around them for maximum enchanting power, and I wouldn't want them to be max level when used from the inventory. But then making them only able to do level 1-3 enchantments makes it a pretty useless feature

@IceX2457:

Well for the enchanting table I can see you checking the number of bookshelves in the inv of the person

@percyqaz:

Users may not naturally understand that they need bookshelves in the same inventory, since every other feature of this plugin just involves right-clicking on a self-contained item, so there could be a better way if I spend some more time thinking about it


So if I have additional thoughts on how to make this intuitive/easy to interact with maybe this will be a feature, although it's pretty low priority to me as I like having an area in my base for enchanting where I store enchanting-related items

percyqaz commented 9 months ago

I've tried this out on the Paper API and it seems that the enchanting GUI opened has a max level depending on how many bookshelves you are standing near at the time

This makes it basically pointless to add this feature (why not just right click on a table in the world) unless there is a clean way to set the max enchanting level to 30

I still need to test what it does on the plain Spigot API (if different), but this basically rules out enchanting tables as a feature

Possible follow ups: