perfanalytics / pose2sim

Markerless kinematics with any cameras — From 2D Pose estimation to 3D OpenSim motion
https://perfanalytics.github.io/pose2sim/
BSD 3-Clause "New" or "Revised" License
270 stars 50 forks source link

Did the expected format of json change with latest 0.9 version ? #117

Closed ANaaim closed 4 months ago

ANaaim commented 4 months ago

Hi,

I was wondering if the format of the expected json was changed in latest version (0.9)?

Best regards,

davidpagnon commented 4 months ago

It shouldn't, do you experience any issues?

The main difference is that we don't use body_25 or body_25B openpose models anymore, but Halpe_26, which uses a different keypoint ordering.

ANaaim commented 4 months ago

ERROR : the problem come from the fact that it is supposed that the json are supposed to be in the person association

==> is it necessary even if no person association is done ?

davidpagnon commented 4 months ago

You're right, I messed it up, thank you for spotting it! I'll fix it right now

ANaaim commented 4 months ago

Cool. so no need to copy the data from a the pose folder to a pose-associated ?

davidpagnon commented 4 months ago

Can you confirm that it works with the last patch on triangulation.py? You should not have to copy anything, no.

ANaaim commented 4 months ago

i should do a pip update pose2sim ?

davidpagnon commented 4 months ago

I haven't released it yet but you can copy-paste the content of the file in your environment (do pip show pose2sim to see where it is located), restart python and try again.

ANaaim commented 4 months ago

I will test this.

ANaaim commented 4 months ago

it work with the new version of triangulation. Let me know when it is integrated in the pip install

ANaaim commented 4 months ago

Hi David, did you integrate the modif in a new version that can be installed with pip ?

Thanks.

davidpagnon commented 4 months ago

Hi, Sorry I initially wanted to wait until more changes were made but it does not make sense, I just pushed the last release to pypi