search

perfectline / validates_url

URL Validation for Rails
MIT License
583 stars 113 forks source link

Update CI so it runs correctly for Ruby 2.3 - Ruby head #150

Open petergoldstein opened 1 year ago

petergoldstein commented 1 year ago

This PR required some modernization of the gemspec, changes to the CI file, and a minor code change. Everything runs green on my fork.

Also updates checkout action to v3, allowing it to run (v2 and earlier no longer run properly)

kritik commented 1 year ago

why are you dropping public_suffix and jewellery?

petergoldstein commented 1 year ago

I didn't drop public_suffix. It's still in the gemspec and the generated Gemfile.lock.

I dropped jeweler because it has compatibility issues with recent Rubies, and the functionality is all incorporated into bundler at this point. Even the maintainer of jeweler no longer recommends it at this time.