search

perforce / p4prometheus

[Community Supported] Perforce (Helix Core) interface for writing Prometheus metrics from real-time analysis of p4d log files.
MIT License
41 stars 24 forks source link

Handle server=1 logs #4

Open rcowham opened 4 years ago

rcowham commented 4 years ago

Such logs do not have a completed record. Needs to be detected and handled appropriately.

rcowham commented 3 years ago

Note there is better handling of these - there will be a panic and an appropriate error message hopefully. Not sure what else to do at this point.

rmmeta.log: 36.7 MB/598.1 MB 6% estimated finish 11:45:07, 15m18s remaining... rmmeta.log: 36.7 MB/598.1 MB 6% estimated finish 11:45:23, 15m34s remaining... panic: ERROR: max running command limit (20000) exceeded. Does this server log have completion records configured (configurable server=3)?

goroutine 8 [running]: github.com/rcowham/go-libp4dlog.(P4dFileParser).LogParser.func4(0xc0000ff800, 0x9e6160, 0xc0000b91c0) /go/src/github.com/rcowham/go-libp4dlog/p4dlog.go:1421 +0x2b9 created by github.com/rcowham/go-libp4dlog.(P4dFileParser).LogParser /go/src/github.com/rcowham/go-libp4dlog/p4dlog.go:1407 +0x174

rcowham commented 4 months ago

Note that log2sql has a flag to help with this.