search

perforce / p4prometheus

[Community Supported] Perforce (Helix Core) interface for writing Prometheus metrics from real-time analysis of p4d log files.
MIT License
48 stars 24 forks source link

monitor_metrics.sh - 'p4_errors.prom' metrics are not updated if errors.csv file exists and is empty #44

Closed jdputsch closed 10 months ago

jdputsch commented 1 year ago

We have an alert of files read by node_exporter that alarms if those files are not updated in a timely manner. When 'errors.csv' is empty, the metrics.sh script will not udpate the 'p4_errors.prom' file and this leads to alerts for us: indicating a problem with our monitoring scripts.

'p4_errors.prom' should at least get a new modification time every time monitor_metrics.sh is run.

jdputsch commented 1 year ago

Withdrawing .. in this case it's better that we update our alert rule.