perfsonar / psconfig

Configures perfSONAR tests from a central source in an extensible way.
Apache License 2.0
4 stars 2 forks source link

Fix Matrices not showing data when IP specified instead of hostname #121

Closed arlake228 closed 9 months ago

arlake228 commented 9 months ago

There is an issue with the Grafana Agent generated dashboards where if an IP is specifed it does not show up in the dashboard. The problem is that it looks in the hostname field. If the IP has no valid hostname then that field is not populated (which we should also fix so its easier to search) and if it does then the field won't match. To fix this we should use the test.spec fields. The main downside is if no source is specified, which in the pSConfig case should not be true. In the case that it is, people would get strange results today (i.e. pre-5.1.0). The Grafana agent also has config options to look at different fields, so it should be ok.