search

perftools / xhgui

Web interface for XHProf profiling data can store data in MongoDB or PDO database
1.65k stars 341 forks source link

Other DB #11

Closed onigoetz closed 11 years ago

onigoetz commented 11 years ago

Hi,

I know, you made XHGUI because you wanted to be able to use mongoDB.

my question is : is it possible to abstract it to be able to use mysql or other databases ?

I would be happy to write the mysql(i) driver.

for the short story, I wrote a mongo DB driver for your fork of xhprof a few years ago. and had a hard time doing it. I didn't make a pull request at the time because I couldn't get all aggregation methods to work with mongo. request took too long. It's funny that now you want to use only mongo.

markstory commented 11 years ago

Its probably possible, but I don't know if it will happen. Abstracting mongo + mysql into one super set is going to be really hard. Is there a reason you'd prefer using MySQL over mongo?

preinheimer commented 11 years ago

Something to keep in mind, abstracting out the database to allow MySQL for example is currently pretty easy. The plans for this tool however include a lot more leveraging of Mongo. I've got a lot of plans for the custom report page that will extensively leverage being able to address all of the run data (rather than a few cherry picked pieces of information). That will be tricky with MySQL without a lot of normalization, and even then relationships will not be exposed in the same manner.

markstory commented 11 years ago

I think at this point in the project it wouldn't be wise to spend time abstracting databases, I would rather focus on building out the missing features and closing the gap with the old xhprof/ui.

onigoetz commented 11 years ago

The reason for that is that the company i'm working for is looking for solutions to move their front end websites to PHP and I told them that using xhprof would be very useful to track down slownesses on any solution we would come up with (currently, the idea is drupal, and our websites have pretty high traffic)

And they're not ready for noSQL. and currently, from the different xhprof GUI versions, this one seems to be the one that will be the best maintained.

onigoetz commented 11 years ago

do you have some kind of roadmap somewhere if we want to contribute to add these missing features ?

markstory commented 11 years ago

No but that would be a good idea, I'll draft what I had in mind up on a wiki page tonight.

markstory commented 11 years ago

I figure tickets are more actionable than wiki pages, so I made a few tickets of the things I had planned on working on in the next little bit.

markstory commented 11 years ago

Closing this as there are no short/medium term plans to make xhgui work with other databases.