search

perftools / xhgui

Web interface for XHProf profiling data can store data in MongoDB or PDO database
1.65k stars 341 forks source link

Fix perftools/php-profiler link #468

Closed kornrunner closed 2 years ago

kornrunner commented 2 years ago

Changed syntax as [perftools/php-profiler] alias was already defined in the file.

glensc commented 2 years ago

Pardon, but what is the problem you are trying to solve here? and I prefer markdown reflinks for readability. Describe the problem first.

kornrunner commented 2 years ago

Both [perftools/php-profiler] anchors that are rendered on Github repository page (Readme.md) actually link to https://github.com/perftools/xhgui#profiling-a-web-request-or-cli-script which is the value of first markdown reflink.

It seems that Github doesn't process markdown reflink redefinition - thus second link is not linking to the repository page as one might expect (the one being changed within this PR).

glensc commented 2 years ago

perhaps the first link should link to the section in the readme, i.e:

[bla bla bla](#profiling-a-web-request-or-cli-script)
kornrunner commented 2 years ago

Updated first link