personalrobotics / prpy

Python utilities used by the Personal Robotics Laboratory.
BSD 3-Clause "New" or "Revised" License
62 stars 19 forks source link

Add metadata about determinism to the planning pipeline #325

Closed mkoval closed 8 years ago

mkoval commented 8 years ago

This pull request adds three new features to the PrPy planning pipeline:

The trajectory tags default to being absent and the deterministic flag defaults to None. I strongly suggest logging a warning and not silently defaulting to False if they are not set. It is possible that I missed a few calls in the PrPy motion planners that we need to annotate.

This data metadata is correctly propagated by the Sequence, MethodMask, and FirstSupported MetaPlanners. Note that the behavior of Sequence is a bit unintuitive: it will flag a trajectory as non-deterministic if any previous planner in the sequence was non-determinstic.

There are a few additional points of subtly:

mkoval commented 8 years ago

This now needs to be merged after #334. I had to fix that regression to test this code.