search

personalrobotics / prpy

Python utilities used by the Personal Robotics Laboratory.
BSD 3-Clause "New" or "Revised" License
62 stars 19 forks source link

Split tsr #367

Closed Shushman closed 7 years ago

Shushman commented 7 years ago

This branch removes the tsr subfolder from the prpy package and changes the imports to reflect that.

brianhou commented 7 years ago

Tests fail due to an assortment of ImportErrors. The root cause is a tsr.py in prpy.planning that is found before the tsr module. Renaming tsr.py seems to fix that issue. I'll let you pick the new name.

In addition, there were a couple of places that passed the manip parameter to TSR, which seems like it should be manipindex. Changing that in 8dbb20adc8b746562e27b481b51d8c389157df88 made the tests pass.

Shushman commented 7 years ago

These are the changes so that prpy/tests/planning now all run:

Shushman commented 7 years ago

The final commit is to base/robot.py to change the constructor call to tsrlibrary The call now provides the manipindex argument to be compatible with tsr without OpenRAVE dependencies. So this merge should happen after tsr is updated to merge the remove_or_deps