search

personium / app-personium-trails

Application for sharing your location history.
Apache License 2.0
5 stars 5 forks source link

How about using serviceSubject instead of APP_CELL_ADMIN_INFO #12

Closed yoh1496 closed 2 years ago

yoh1496 commented 4 years ago

In acc_info.js, we hard-coded the admin password.

https://github.com/personium/app-personium-trails/blob/5c97a33cda16f89e38c71a44c473a8a99d294b21/src/app/auth/acc_info.js

maybe, this occurs some security problem.

how about using serviceSubject instead of APP_CELL_ADMIN_INFO in auth

https://github.com/personium/app-personium-trails/blob/5c97a33cda16f89e38c71a44c473a8a99d294b21/src/app/auth/personium.js#L25

dixonsiu commented 3 years ago

I just find out that the service subject is usable in the following command, too. It will retrieve the box object where the script is in.

_p.as('serviceSubject').cell().box()