pesekon2 / GRASS-GIS-SOS-tools

My Google Summer of Code 2017 project. This is just development part. Intended GRASS GIS modules and final code will be at https://svn.osgeo.org/grass/grass-addons/
GNU General Public License v2.0
3 stars 1 forks source link

response_format supported options #4

Closed lucadelu closed 7 years ago

lucadelu commented 7 years ago

I propose to use options parameter (like here ) for response_format (used here ) to permit to use only the supported responseFormat

pesekon2 commented 7 years ago

The only problem is that not every responseFormat is supported for both SOS versions (1.0.0. and 2.0.0.). For example the standardized text/xml;subtype="om/1.0.0" is supported only for version 1.0.0. Should I reflect it somehow, or should I write there all of them?

I think that the best idea is to write there (into options) just those implemented in module, now text/xml;subtype="om/1.0.0" and text/json, because it doesn't make sense to choose text/plain when text/xml;subtype="om/1.0.0" should be provided in every SOS 1.0.0.

lucadelu commented 7 years ago

Yes please, add only the implemented in the module.

Maybe add a check if responseFormat is text/xml;subtype="om/1.0.0" and SOS version is 1.0.0