search

pest-parser / pest

The Elegant Parser
https://pest.rs
Apache License 2.0
4.67k stars 262 forks source link

propagate non_exhaustive attribute to the generated Rule enums #901

Closed tomtau closed 1 year ago

NoahTheDuke commented 1 year ago

This seems like a big change. Is bumping the patch version enough?

Otherwise, code looks good.

tomtau commented 1 year ago

This seems like a big change. Is bumping the patch version enough?

Otherwise, code looks good.

The external interfaces remain the same, so at least semver-wise it should be, but it's a new "feature" in a way. Would you suggest bumping a minor version instead?

NoahTheDuke commented 1 year ago

My apologies, I misread and thought pub(crate) was simply pub in generator. This is fine by me.