search

pestphp / pest-plugin-watch

The Pest Plugin Watch
https://pestphp.com
MIT License
17 stars 10 forks source link

This plugin needs to be tested on other OS's besides Mac #7

Open nunomaduro opened 4 years ago

owenvoke commented 4 years ago

I should be able to test it on Linux (Ubuntu) and Windows. Windows is a pain to install fswatch on so far though.

nunomaduro commented 4 years ago

Hummm, maybe you can update the docs on that regard?

owenvoke commented 4 years ago

I've managed to get this working on Linux. On Windows (under WSL), it runs, but doesn't actually appear to watch the directories. 🤔

fetzi commented 3 years ago

Maybe it would be an option to rewrite the plugin and use yosymfony/resource-watcher like spatie/phpunit-watcher does. Then the fswatch dependency can be dropped.

What do you think?

Would be open for providing an implementation for that.

owenvoke commented 3 years ago

@fetzi, I guess we could 🤷🏻 That would resolve the issue that fswatch doesn't seem to have pre-compiled binaries for Windows.

Are there any performance issues with that package? 🤔 Just wondering, if it uses PHP under the hood, whether it'd struggle with watching a large set of directories/files.

fetzi commented 3 years ago

I don't see performance issues for the majority of projects and yes it uses PHP under the hood.

owenvoke commented 3 years ago

Nice! Feel free to implement a change for it. 👍🏻

agustinprod commented 3 years ago

I'm having a lot of issues using this plugin on ubuntu / docker. It triggers infinite runs because phpstorms triggers access to the files just by reading them, so this becomes unusable.

The good news is that you can still use the https://github.com/spatie/phpunit-watcher , and it gives a better DX by having interactive filtering. Maybe this plugin should fork spaties one. If anyone want to try it, just set the binary Path to pest on the .phpunit-watcher:


phpunit:
  binaryPath: vendor/bin/pest
  directories:
    - src
    - database
    - resources
    - tests