search

peterdesmet / petridish

Jekyll theme for research project websites 🧫
https://peterdesmet.github.io/petridish
MIT License
49 stars 44 forks source link

Support Disqus commenting by enabling configuration of EXAMPLE Disqus URL #80

Closed jocelynpender closed 1 year ago

jocelynpender commented 1 year ago

I've created a Disqus site for my site. However, it's not functioning and I'm pretty confident that it's because EXAMPLE needs to be replaced by my site name on this line of the Petridish default layout. I can certainly create my own version of the default.html layout that is unique to my site and separate from the theme, but I thought I would flag this for you so that it might be a configuration variable for folks in the future.

peterdesmet commented 1 year ago

Thanks for reporting, that is indeed a bug.

peterdesmet commented 1 year ago

I'm thinking of including the Disqus site config as one of the socials in _config.yml. Does that make sense?

socials:
  twitter: peterdesmet
  github: github_username
  disqus: disqus_sitename # https://<disqus_sitename>.disqus.com/

It would not be listed as one of the footer icons.

jocelynpender commented 1 year ago

Yes, this makes sense! I was thinking of the same idea for a solution 😄

peterdesmet commented 1 year ago

This is now fixed and retroactively included in 3.0. So you can still reference:

remote_theme: peterdesmet/petridish@3.0

The feature is documented at http://peterdesmet.com/petridish/docs/configuration/#blog-posts