search

peterh / liner

Pure Go line editor with history, inspired by linenoise
MIT License
1.04k stars 132 forks source link

Fix double width fonts for less common cases #105

Closed jnjackins closed 6 years ago

jnjackins commented 6 years ago

After seeing @roachsinai's issue in #43, I tried changing the width calculations to use @mattn's library. This fixes the issue and seems much simpler than trying to solve the same problem again from scratch. :)

roachsinai commented 6 years ago

Thank you! @jnjackins

roachsinai commented 6 years ago

Hi, @peterh does thiss pull requests have problem? Could you pls merge it?

peterh commented 6 years ago

does thiss pull requests have problem?

This is the first time liner depends on any external package. It took me some time to get comfortable with the idea (plus I've been rather busy lately, and haven't had time to review the pull request details).

Could you pls merge it?

Done. Thanks @jnjackins for the pull request.

roachsinai commented 6 years ago

Thanks for you work! @peterh :-)