search

peterh / liner

Pure Go line editor with history, inspired by linenoise
MIT License
1.04k stars 132 forks source link

Expand word separators list for alt-{f, b, d}, ctrl-w combinations #112

Open reinerRubin opened 6 years ago

reinerRubin commented 6 years ago

Hello, I love console things and enjoy "geth console" (go-ethereum) for dev-purposes. It uses the liner project.

eth.getTransactionReceipt('0xe7e83a25593e7f068a65994b2fd4226bf9fd16b6ce4abb4796c382e32eeedd57')

Strings like this are very common. And it would be very convinient if you could jump to " ( ", " ' " symbols or delete hash up to " ' ". Plus it's a bash default behavior. So I've made this pr.

I can add configurations and make this mode optional if you want. But in my opinion it's not needed.

Thanks.

frou commented 6 years ago

FYI this topic was discussed a bit in an old unmerged PR #49

reinerRubin commented 6 years ago

Thanks!

I tried to find something about custom separators but failed. If @peterh's suggestion about "SetWhitespaceFunc" is still alive, I can do it.

peterh commented 5 years ago

Sorry for the late reply.

The general guideline (aside from single line mode) for defaults is "what does bash do?"

I just tested, and bash treats punctuation and whitespace the same for Ctrl-← and Ctrl-→ (and Alt-F and Alt-B), but only looks at whitespace for Ctrl-W.

Argh. I hate that bash is inconsistent here, so I can probably be persuaded that this change is correct, but I'd like to see more discussion of the pros and cons of this behaviour compared to adopting the bash behaviour.