search

peterh / liner

Pure Go line editor with history, inspired by linenoise
MIT License
1.04k stars 132 forks source link

Rename files for consistency #141

Closed ichizok closed 3 years ago

ichizok commented 3 years ago

I think better to rename some files for the consistency in the sight of golang style, i.e. {filename}_{arch/os}.go

peterh commented 3 years ago

Thanks for the suggestion. While I appreciate the sentiment, I'm not pulling this for two reasons:

  1. The file tags others, bsd, and unix are not tags recognized by the go tool today. If any of them become recognized tags in the future, it could result in miscompilation (especially if, for example, unix excludes Linux because unlike macOS, Linux has never qualified for the UNIX trademark).
  2. An import of "unsafe" should be restricted to the smallest file possible. I'm not in favour of moving it from unixmode to input.