minor vet/lint fixes - Githubissues

peterh / liner

Pure Go line editor with history, inspired by linenoise

MIT License

1.04k stars 132 forks source link

minor vet/lint fixes #84

Closed tzneal closed 7 years ago

peterh commented 7 years ago

Sorry for the late reply.

The KillRingMax and refresh() fixes are good, but the returns that go vet complains about are there for compatibility with go1.0.

See https://golang.org/doc/go1.1#return

It may be that it is time to drop go1.0 support, but the commit message should prominently call out the fact that it's dropping go1.0 support (and also remove signal.go/signal_legacy.go).

peterh commented 7 years ago

Given that:

go1.0 doesn't build from source any more
go1.0 binaries are no longer available
liner's go1.0 support was broken two years ago and nobody has complained since

I think it's time to stop pretending we work on go1.0. I've made a commit that removes signal.go and calls out the unsupported status of go1.0, and then merged your change. Thanks for the patch!