search

peterhuene / sqlite-net-wp8

A C++/CX wrapper for SQLite functions that sqlite-net depends on. Can be used as an alternative to csharp-sqlite on Windows Phone 8. This library is released under the MIT license.
MIT License
74 stars 65 forks source link

Add interrupt to faciliate Async #45

Closed tofutim closed 9 years ago

tofutim commented 9 years ago

A small change, but I need it for to interrupt async stuff. Thanks for all the great work.

peterhuene commented 9 years ago

I no longer maintain this project, but I don't see the harm in merging this in.

peterhuene commented 9 years ago

Wait, sorry, was this missing a corresponding change to the header?

tofutim commented 9 years ago

Good catch, yes, I forgot to commit that. Let me do that. I can also help be an official fork or contributor if you still need that.

On Tue, Dec 16, 2014 at 4:38 PM, Peter Huene notifications@github.com wrote:

Wait, sorry, was this missing a corresponding change to the header?

— Reply to this email directly or view it on GitHub https://github.com/peterhuene/sqlite-net-wp8/pull/45#issuecomment-67259519 .

tofutim commented 9 years ago

Should be there now.

On Tue, Dec 16, 2014 at 4:40 PM, E. Timothy Uy tim@loqu8.com wrote:

Good catch, yes, I forgot to commit that. Let me do that. I can also help be an official fork or contributor if you still need that.

On Tue, Dec 16, 2014 at 4:38 PM, Peter Huene notifications@github.com wrote:

Wait, sorry, was this missing a corresponding change to the header?

— Reply to this email directly or view it on GitHub https://github.com/peterhuene/sqlite-net-wp8/pull/45#issuecomment-67259519 .

tofutim commented 9 years ago

2nd pull. Do you also update the nuget?

On Tue, Dec 16, 2014 at 4:42 PM, E. Timothy Uy tim@loqu8.com wrote:

Should be there now.

On Tue, Dec 16, 2014 at 4:40 PM, E. Timothy Uy tim@loqu8.com wrote:

Good catch, yes, I forgot to commit that. Let me do that. I can also help be an official fork or contributor if you still need that.

On Tue, Dec 16, 2014 at 4:38 PM, Peter Huene notifications@github.com wrote:

Wait, sorry, was this missing a corresponding change to the header?

— Reply to this email directly or view it on GitHub https://github.com/peterhuene/sqlite-net-wp8/pull/45#issuecomment-67259519 .

peterhuene commented 9 years ago

I don't anymore. I'd be happy to add you as an owner to the nuget package so you can update it if you wish (just need your nuget username). If you'd like to become the official fork, I'll also update the README to point at yours.

tofutim commented 9 years ago

my nuget username is 'tofutim'

Let's wait on official fork though. Are you really done with this project?

On Tue, Dec 16, 2014 at 4:46 PM, Peter Huene notifications@github.com wrote:

I don't anymore. I'd be happy to add you as an owner to the nuget package so you can update it if you wish (just need your nuget username). If you'd like to become the official fork, I'll also update the README to point at yours.

— Reply to this email directly or view it on GitHub https://github.com/peterhuene/sqlite-net-wp8/pull/45#issuecomment-67260242 .

tofutim commented 9 years ago

Yeah, I think you better pass it to me so I can increment the version.

On Tue, Dec 16, 2014 at 6:35 PM, E. Timothy Uy tim@loqu8.com wrote:

my nuget username is 'tofutim'

Let's wait on official fork though. Are you really done with this project?

On Tue, Dec 16, 2014 at 4:46 PM, Peter Huene notifications@github.com wrote:

I don't anymore. I'd be happy to add you as an owner to the nuget package so you can update it if you wish (just need your nuget username). If you'd like to become the official fork, I'll also update the README to point at yours.

— Reply to this email directly or view it on GitHub https://github.com/peterhuene/sqlite-net-wp8/pull/45#issuecomment-67260242 .

peterhuene commented 9 years ago

Sorry, was on a 13 hour flight until a little while ago. I've added you as a collaborator on my GitHub project (feel free to just change it to point at yours) and as an owner on the NuGet package. Thanks!

tofutim commented 9 years ago

13 hour flight sounds fun. Where in the world did you go?

Best wishes, Tim

On Wed, Dec 17, 2014 at 11:01 AM, Peter Huene notifications@github.com wrote:

Sorry, was on a 13 hour flight until a little while ago. I've added you as a collaborator on my GitHub project (feel free to just change it to point at yours) and as an owner on the NuGet package. Thanks!

— Reply to this email directly or view it on GitHub https://github.com/peterhuene/sqlite-net-wp8/pull/45#issuecomment-67373890 .

peterhuene commented 9 years ago

Currently in Abu Dhabi. Traveling to my honeymoon in the Seychelles. Cheers!

tofutim commented 9 years ago

Wow! Congratulations. Have a wonderful honeymoon, and for goodness sake, stop checking email from me. :)

On Wed, Dec 17, 2014 at 11:03 AM, Peter Huene notifications@github.com wrote:

Currently in Abu Dhabi. Traveling to my honeymoon in the Seychelles. Cheers!

— Reply to this email directly or view it on GitHub https://github.com/peterhuene/sqlite-net-wp8/pull/45#issuecomment-67374170 .