search

peterknife / boto

Automatically exported from code.google.com/p/boto
0 stars 0 forks source link

Surprising add_tag() exception on ec2objects #462

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I get:

  TypeError: 'NoneType' object does not support item assignment

when I do (e.g.):

  inst.add_tag('Name', 'foo')

because inst.tags is None.

What does it take to make .tags not-None?

Original issue reported on code.google.com by yaa...@gmail.com on 5 Oct 2010 at 8:58

GoogleCodeExporter commented 9 years ago 
It takes me fixing the code.  Sorry about that, still working through the 
tests.  I'll update this later this evening.

Original comment by Mitch.Ga...@gmail.com on 5 Oct 2010 at 9:49

GoogleCodeExporter commented 9 years ago 
Fixed in 
http://github.com/boto/boto/commit/a6bf77b31fa6d27f73ee45f7b6c046dc9268c55a

Original comment by Mitch.Ga...@gmail.com on 5 Oct 2010 at 10:57

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Thanks!

Original comment by yaa...@gmail.com on 6 Oct 2010 at 12:39

GoogleCodeExporter commented 9 years ago 
I think this issue was fixed as a side effect of adding support for tags into 
launch_instance command.
http://github.com/boto/boto/commit/30ac504706790f881e1ace180d2dcc1205102cf3

Maybe the "if block" in add_tag method now needless.

Ales.

Original comment by ales.zou...@gmail.com on 6 Oct 2010 at 8:21