Fix bug in polygon validation

peterstace / simplefeatures

Simple Features is a pure Go Implementation of the OpenGIS Simple Feature Access Specification

MIT License

131 stars 19 forks source link

Fix bug in polygon validation #632

Closed peterstace closed 2 months ago

peterstace commented 2 months ago

Description

The bug caused some invalid polygons to be incorrectly identified as valid. Specifically, the bug occurred when an inner ring is outside of the outer ring, and the first control point of the inner ring is touching the outer ring.

Check List

Have you:

Added unit tests? Yes.
Add cmprefimpl tests? (if appropriate?) N/A.
Updated release notes? (if appropriate?) Yes.

Related Issue

https://github.com/peterstace/simplefeatures/issues/631

peterstace commented 2 months ago

Thanks for the review @albertteoh ! 🥳