petgraph / fixedbitset

A simple bitset container for Rust
https://docs.rs/fixedbitset/
Apache License 2.0
127 stars 47 forks source link

Shirnk stack size of FixedBitset #118

Closed james7132 closed 8 months ago

james7132 commented 8 months ago

The length in the Vec is redundant with the separate length in bits, making FixedBitset have some stack size overhead compared to a Vec. This PR removes that extra length, using the bit length to figure out the block length when necessary.

Ran benchmarks and saw no significant regressions.

zh-jq-b commented 8 months ago

This change makes FixedBitSet !Send, which breaks our code https://github.com/bytedance/g3/pull/191

james7132 commented 8 months ago

That should be fixed as of 0.5.6 and #124.