petrpavlu / valgrind-riscv64

Valgrind with support for the RISCV64/Linux platform.
GNU General Public License v2.0
56 stars 16 forks source link

riscv64: Add Zfh extension support #12

Closed rjiejie closed 1 year ago

rjiejie commented 1 year ago

This patch make following simple design rules:

rjiejie commented 1 year ago

However, it makes me wonder how to best approach merging this work. My thinking is to initially submit upstream for review only the current RV64GC support, make maintainers aware that some new Iops will be needed for RISC-V, and once the port lands, have a separate upstream review for the FP16 support.

That also means that I would merge this FP16 work in this repository on a separate branch for now, or the other way around, create a new branch for only the code that should go upstream in the first batch.

Thanks for all comments @petrpavlu @paulfloyd I agree with your opinion, we should upstream RVGC as base code for RISCV first :)