fix: adjust the way how querySelector find data-testid in e2e test

petyosi / react-virtuoso

The most powerful virtual list component for React

https://virtuoso.dev

MIT License

5.13k stars 299 forks source link

fix: adjust the way how querySelector find data-testid in e2e test #1075

Closed ts1994tw closed 4 months ago

ts1994tw commented 4 months ago

Overview

Adjust the way how querySelector find data-testid in e2e test

Changes

Instead of use querySelector find by data-test-id, but find by data-testid

Check

Conclusion

This is my last PR about data-testid at this moment. Thanks for having me this chance to contribute.

If purpose of this PR is focused enough and seems like a good fix, it'd be cool to see it become part of the library. Finally, appreciated for your time, and kudos for your fantastic works in open-source 🙇

petyosi commented 4 months ago

Thank you for your help. I find/replaced those when I merged the previous two PRs. Otherwise, the e2e would fail in the build process.

ts1994tw commented 4 months ago

@petyosi Got it. Thanks for your looking back also apologized for delivering these changes a bit late cause I just finished my daily jobs.

Hope you would be happy to have these changes, it's my pleasure as well.