Make as a hyperlink the screenshot path automatically taken by System Spec

[kzkn]

Make as a hyperlink the screenshot path automatically taken by RSpec's System Spec.

Example:

RSpec.describe "テスト", type: :system, js: true do
  it "内容が表示されること" do
    # this will be fail, system spec will take a screenshot automatically.
    expect(page).to have_content "ハロー"
  end
end

Outputs:

  1) テスト 内容が表示されること
     Failure/Error: expect(page).to have_content "ハロー"
       expected to find text "ハロー" in ""

     [Screenshot]: /home/kazuki/myproj/tmp/screenshots/failures_r_spec_example_groups_nested_2_内容が表示されること_237.png

This pull request makes the above path as a hyperlink.

[dgutov]

Hi!

What about the preceding rule? Does that format come from a different setup? Or a previous version of Capybara?

[kzkn]

@dgutov

  '((rspec-capybara-html "^ +HTML screenshot: \\([0-9A-Za-z@_./\:-]+\\.html\\)" 1 nil nil 0 1)
    (rspec-capybara-screenshot "^ +Image screenshot: \\([0-9A-Za-z@_./\:-]+\\.png\\)" 1 nil nil 0 1)

They are output formats by capybara-screenshot gem. It's still a good way in the old style of feature specs to take a screenshot automatically on fail a spec.

    (rspec-system-spec-screenshot "^ +\\[Screenshot\\]: \\(.+\\.png\\)" 1 nil nil 0 1)

This is an output format by System Test that built-in Rails. RSpec's System Spec is a wrapper of it.

[dgutov]

Makes sense, thank you. So both formats need to be supported.

Could you modify the previous rule, though, instead of adding a new one? They only differ in the first two words, I think. And brackets.

[kzkn]

@dgutov Thanks. Let me just check one thing. Do you mean merge rspec-capybara-html, rspec-capybara-screenshot and rspec-system-spec-screenshot? Or merge rspec-capybara-screenshot and rspec-system-spec-screenshot?

[dgutov]

Or merge rspec-capybara-screenshot and rspec-system-spec-screenshot?

Let's go with this one.

[kzkn]

@dgutov I did it :smiley:

[dgutov]

Could you keep the bol anchoring (^ +)? It's better for performance.

You might also want to use grouping and the alternation instruction (\\|).

[kzkn]

@dgutov thanks. I did it.

[dgutov]

Um, this part doesn't make sense: \\(\\|.

Let's revert that part to the previous version. But keep the bol anchoring.

[kzkn]

ok, did it.

[dgutov]

Thanks!