compile: Save group number to allow recursive group specs.

pfalcon / re1.5

re1, the unbloated regexp engine by Russ Cox, elaborated to be useful for real-world applications

BSD 3-Clause "New" or "Revised" License

41 stars 4 forks source link

compile: Save group number to allow recursive group specs. #1

Closed dpgeorge closed 9 years ago

dpgeorge commented 9 years ago

prog->sub is possibly modified by the recursive call to _compilecode, so we must save a local copy with our current value.

dpgeorge commented 9 years ago

Fixes https://github.com/micropython/micropython/issues/1122.

pfalcon commented 9 years ago

So, what about tests for these? When I started to add features, I thought that I don't have resources to introduce proper testsuite here on re1.5 side, but rather there will be tests in uPy, to cover both projects. So would, there be accompanying uPy tests?

dpgeorge commented 9 years ago

Yes I have some uPy tests for this that I did not push because they would fail. I considered making a proper test suite for re1.5 but didn't :) Might be a good idea so that this repo can be standalone, and it would make it easier to fix bugs (currently I did all dev in uPy then copied files back to re1.5).

pfalcon commented 9 years ago

Merged, thanks.