search

pfalcon / re1.5

re1, the unbloated regexp engine by Russ Cox, elaborated to be useful for real-world applications
BSD 3-Clause "New" or "Revised" License
41 stars 4 forks source link

Qnongreedy #24

Closed ampli closed 9 years ago

ampli commented 9 years ago

ARM: +40 x86_64: +36

The greedy/non-greedy code repeats 3 times (for ?, * and +). If it is replaced by the macro EMIT_COND (see #14) it saves significant code space, while simplifying the source code.

Please indicate if a pull request for that is a good idea (already implemented).

In addition, see there (#14) for an open question of sending a pull request to revert the PC macro change (that is good for x86_64 but very bad for ARM), or to make it ifdef'ed something.

ampli commented 9 years ago

I see a redundant Merge branch 'master' has been created. I will force push again without it in a few minutes...

EDIT: Done.

ampli commented 9 years ago

I have just added indentation fix of a previous change to this file. However, the push added the recent commits already added.

Again, I will force push without it in a few minutes...

EDIT: Done.

pfalcon commented 9 years ago

If it is replaced by the macro EMIT_COND (see #14) it saves significant code space, while simplifying the source code. Please indicate if a pull request for that is a good idea (already implemented).

Ok, let's go for it.

pfalcon commented 9 years ago

Merged, thanks.