search

pfnet-research / menoh

Menoh: fast DNN inference library with multiple programming language support
MIT License
279 stars 34 forks source link

refactor CMakeLists #179

Closed okdshin closed 5 years ago

okdshin commented 6 years ago
msakai commented 6 years ago

libmenoh.so is now linked with libonnx.so and libonnx_proto.so. Is this an intended change?

Also, it fails to compile with MSVC. cc: @durswd

msakai commented 5 years ago

I noticed that if an older version of menoh is installed to the system, its header files are referenced with priority. This sometimes causes build failure like the following.

In file included from /Users/sakai/menoh/menoh/onnx.cpp:16:
In file included from /Users/sakai/menoh/menoh/array.hpp:9:
/Users/sakai/menoh/menoh/dtype.hpp:29:17: error: use of undeclared identifier 'menoh_dtype_int32'; did you mean 'menoh_dtype_float'?
        int32 = menoh_dtype_int32,
                ^~~~~~~~~~~~~~~~~
                menoh_dtype_float
/usr/local/include/menoh/menoh.h:47:5: note: 'menoh_dtype_float' declared here
    menoh_dtype_float,
    ^
okdshin commented 5 years ago

Thanks!