cmake script does nt check gcc version

pfnet-research / menoh

Menoh: fast DNN inference library with multiple programming language support

MIT License

279 stars 34 forks source link

cmake script does nt check gcc version #204

Closed WilliamTambellini closed 5 years ago

WilliamTambellini commented 5 years ago

I know the doc/md file correctly requires gcc 4.9 but in case someone tries to use an older gcc then cmake continues and then some (hard to understand for newcomers) compilation errors happen at make/compilation time.

Should nt the main cmake script check gcc verison ?

example:

if (CMAKE_COMPILER_IS_GNUCC) if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.9) message(FATAL_ERROR "blablabla") endif() endif()

okdshin commented 5 years ago

Thank you for your report. We will fix CMakeLists.txt as you mentioned. Requirements shoud be checked at cmake time.

okdshin commented 5 years ago

This is fixed. Thank you report!