search

pganalyze / pg_query

Ruby extension to parse, deparse and normalize SQL queries using the PostgreSQL query parser
BSD 3-Clause "New" or "Revised" License
790 stars 85 forks source link

Readme examples normalized with ? no longer parse #276

Closed ankane closed 1 year ago

ankane commented 1 year ago

Hi, some of the examples in the readme no longer parse (and should probably be removed) since support for ? was dropped in libpg_query 14-3.0.0, like:

PgQuery.parse("SELECT ? FROM x WHERE y = ?")

Also, the changelog dates seem a bit off compared to RubyGems.

lfittl commented 1 year ago

@ankane Good catch! We no longer support that syntax since the Postgres versions that generated this in pg_stat_statements are now EOL. I'll make a PR to update the README.

The changelog dates between CHANGELOG and RubyGems are different since they are technically separate processes on our end (and we had a delay in publishing the latest release 4.2.0). We may make the release automatic in the future, but currently its an explicit step.

ankane commented 1 year ago

Thanks @lfittl!

fwiw, the changelog dates for the latest two releases have the wrong year, but in general, I think it'd be helpful for users if it matched the date it was released on RubyGems (+/- 1 day for time zone differences).