search

pganalyze / pg_query

Ruby extension to parse, deparse and normalize SQL queries using the PostgreSQL query parser
BSD 3-Clause "New" or "Revised" License
790 stars 85 forks source link

CI: Add Ruby 3.2 #283

Closed arturoherrero closed 1 year ago

arturoherrero commented 1 year ago

Description

Add Ruby 3.2 CI support.

arturoherrero commented 1 year ago

Hi @lfittl, I'm curious to know how far we are in bringing support for Ruby 3.2. I'm creating this to see if we have any CI failures. Thanks!

arturoherrero commented 1 year ago

It looks like we have to update the google-protobuf gem to fix the job failure.

google-protobuf-3.21.12-x86_64-linux requires ruby version < 3.2.dev, >= 2.5, which is incompatible with the current version, 3.2.2

Related to https://github.com/protocolbuffers/protobuf/issues/11578 and https://github.com/protocolbuffers/protobuf/issues/11538.

arturoherrero commented 1 year ago

@lfittl I'm not sure if 12d0387 is enough 😉

arturoherrero commented 1 year ago

It works! On the other hand, we should drop support of Ruby 2.5 because it's incompatible with the gem update. See the new job failure.

google-protobuf-3.22.3-x86_64-linux requires ruby version < 3.3.dev, >= 2.6, which is incompatible with the current version, 2.5.9

I think it's okay because Ruby 2.5 End-Of-Life was 2021-04-05 (2 years ago)

Reference: https://www.ruby-lang.org/en/downloads/branches/

arturoherrero commented 1 year ago

@lfittl please review my previous message and 284b977. This should be ready now.

arturoherrero commented 1 year ago

👋 @lfittl Friendly reminder about this. Thanks!