pgaskin / NickelMenu

The easiest way to launch scripts, change settings, and run actions on Kobo e-readers.
https://pgaskin.net/NickelMenu
MIT License
507 stars 24 forks source link

Incorrect error messages returned from config parser #99

Closed pgaskin closed 3 years ago

pgaskin commented 3 years ago

This is a regression during the refactor in ee0eb7ccf735ad26593cb5a4804b746e273469b4 (#47). The nm_config_parse__line_* functions should have returned true on error, but were returning NULL (i.e. false) instead, causing nm_config_parse to treat it as an unknown line type instead of returning the more specific error message.

This regression does not cause any issues other than vague error messages being returned.

Possibly related to https://github.com/pgaskin/NickelMenu/pull/98#issuecomment-738240153.