pgjones / hypercorn

Hypercorn is an ASGI and WSGI Server based on Hyper libraries and inspired by Gunicorn.
MIT License
1.18k stars 105 forks source link

Make handling of 'root_path' in dispatcher middleware adhere to ASGI spec #259

Open DaGenix opened 1 month ago

DaGenix commented 1 month ago

Before this change, the dispatcher middleware didn't do anything with 'root_path'. It did, however, modify 'path'.

The problem with this behavior, is that the child ASGI app has no way to determine what its prefix it. And if it can't determine its prefix, it doesn't know how to construct URLs.

The ASGI spec isn't super clear on the expected behavior. However, some resources to review are:

Based on the above, I believe that the correct behavior is that "root_path" should be updated by the dispatcher middleware but that "path" should not be modified.

In addition to the above change, I also updated the tests. And I also added a new test case where the dispatcher middleware is nested inside of itself.