pgosar / CyberNvim

CyberNvim: A IDE-like Neovim distribution. Simplicity is Power.
Apache License 2.0
340 stars 11 forks source link

Improved CyberNvim #12

Closed olivertzeng closed 6 months ago

olivertzeng commented 7 months ago

various improvements in this commit including formatted the lua files added submodule for new users removed deprecated plugins software like bashtop to btop, and api functions and alphabetically ordered a lot of stuff

pgosar commented 7 months ago

Thanks for the PR

Don't remove the example config, that's pretty important. I'll take a look at the rest later

olivertzeng commented 7 months ago

Well the example config is already in the lua/user directory Sent from Proton Mail for iOS 於 週五, 4月 19, 2024 時間 00:02, Pranay Gosar @.***> 寫道: Thanks for the PR Don't remove the example config, that's pretty important. I'll take a look at the rest later

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

olivertzeng commented 7 months ago

But it’s not named example config Sent from Proton Mail for iOS 於 週五, 4月 19, 2024 時間 00:02, Pranay Gosar @.***> 寫道: Thanks for the PR Don't remove the example config, that's pretty important. I'll take a look at the rest later

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

pgosar commented 7 months ago

the one in user is the personal config. example is separate

olivertzeng commented 7 months ago

Oh really? Good to know because I thought that it is just the same file as user/user_config.luaI’ll revert the changesYou can check out my main branch to see how I have managed to have a proper nvim config without that fileNormally I wouldn’t like that because of the file nameYou prob should call it settings.lua and have a comment say that it’s an example fileShould I do the latter or the formerMessage ID: @.***>

pgosar commented 7 months ago

I think example_user_config is pretty clear, let's keep it as it was for now

olivertzeng commented 7 months ago

Oh ok because when I first used cybernvim I just renamed that file to user and it then didn’t workAs a user I thought that the name example-xxx should be renamed to xxxBut I agree with you I’ll get that file back Sent from Proton Mail for iOS 於 週五, 4月 19, 2024 時間 07:10, Pranay Gosar @.***> 寫道: I think example_user_config is pretty clear, let's keep it as it was for now

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

pgosar commented 7 months ago

I also immediately get errors. I would avoid getting rid of some of those setup calls. Be sure to test everything image

olivertzeng commented 7 months ago

I also immediately get errors. I would avoid getting rid of some of those setup calls. Be sure to test everything

image

Whoops I'll try it later when I'm free

olivertzeng commented 6 months ago

I also immediately get errors. I would avoid getting rid of some of those setup calls. Be sure to test everything image

Alright fixed

try again

olivertzeng commented 6 months ago

@pgosar i've also make some plugins to always fetch the latest including trouble and neo-tree

and also installed better-escape.nvim as well, you can press jj or set it in the config to escape from insert mode

pgosar commented 6 months ago

I would say that the plugin you added is better suited for your personal configuration. Please make sure not to remove the example user configuration, along with the code in plugins that supports disabling plugins. Out of this PR I am mainly interested in the cleanup you have done to the main-options and some of the style changes in various other files.

olivertzeng commented 6 months ago

I would say that the plugin you added is better suited for your personal configuration. Please make sure not to remove the example user configuration, along with the code in plugins that supports disabling plugins. Out of this PR I am mainly interested in the cleanup you have done to the main-options and some of the style changes in various other files.

after some time i've figured out that CyberNvim isn't something like kickstart it's something like lazyvim sorry for that

but tbh i think that since there is about 2k loc it is better to just make the whole codebase itself a neovim config rather than seperating them