search

pgpool / pgpool2

This is the official mirror of git://git.postgresql.org/git/pgpool2.git. Note that this is just a *mirror* - we don't work with pull requests on github. Please subscribe to pgpool-hackers mailing list from our website and submit your patch to this mailing list.
https://www.pgpool.net
Other
326 stars 88 forks source link

Build failure with PG12: pgpool_adm.c:178:14: error: too many arguments to function 'CreateTemplateTupleDesc' #30

Open df7cb opened 5 years ago

df7cb commented 5 years ago

Building against 12beta1:

17:16:03 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fno-omit-frame-pointer -fPIC -I/usr/include/postgresql -I../../include/pcp -I. -I./ -I/usr/include/postgresql/12/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/mit-krb5  -c -o pgpool_adm.o pgpool_adm.c
17:16:03 pgpool_adm.c: In function '_pcp_node_info':
17:16:03 pgpool_adm.c:178:14: error: too many arguments to function 'CreateTemplateTupleDesc'
17:16:03   tupledesc = CreateTemplateTupleDesc(7, false);
17:16:03               ^~~~~~~~~~~~~~~~~~~~~~~
17:16:03 In file included from /usr/include/postgresql/12/server/access/htup_details.h:18,
17:16:03                  from pgpool_adm.c:27:
17:16:03 /usr/include/postgresql/12/server/access/tupdesc.h:94:18: note: declared here
17:16:03  extern TupleDesc CreateTemplateTupleDesc(int natts);
17:16:03                   ^~~~~~~~~~~~~~~~~~~~~~~
17:16:03 pgpool_adm.c: In function '_pcp_pool_status':
17:16:03 pgpool_adm.c:308:13: error: too many arguments to function 'CreateTemplateTupleDesc'
17:16:03    tupdesc = CreateTemplateTupleDesc(3, false);
17:16:03              ^~~~~~~~~~~~~~~~~~~~~~~
17:16:03 In file included from /usr/include/postgresql/12/server/access/htup_details.h:18,
17:16:03                  from pgpool_adm.c:27:
17:16:03 /usr/include/postgresql/12/server/access/tupdesc.h:94:18: note: declared here
17:16:03  extern TupleDesc CreateTemplateTupleDesc(int natts);
17:16:03                   ^~~~~~~~~~~~~~~~~~~~~~~
17:16:03 make[3]: *** [<builtin>: pgpool_adm.o] Error 1
17:16:03 make[3]: Leaving directory '/<<PKGBUILDDIR>>/src/sql/pgpool_adm'
17:16:03 make[2]: *** [Makefile:46: all-pgpool_adm-recurse] Error 2
17:16:03 make[2]: Leaving directory '/<<PKGBUILDDIR>>/src/sql'
17:16:03 make[1]: *** [debian/rules:43: override_dh_auto_install] Error 2
17:16:03 make[1]: Leaving directory '/<<PKGBUILDDIR>>'
17:16:03 make: *** [debian/rules:67: binary] Error 2
17:16:03 dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2
tatsuo-ishii commented 5 years ago

Thanks for the report. I have pushed the fix for all the supported branches.

df7cb commented 5 years ago

Thanks, I'll wait for the next release then.

pgpool-tmp commented 5 years ago

It's already been released. https://pgpool.net/mediawiki/index.php/Main_Page#Pgpool-II_4.0.6.2C_3.7.11.2C_3.6.18.2C_3.5.22_and_3.4.25_officially_