search

phac-nml / biohansel

Rapidly subtype microbial genomes using single-nucleotide variant (SNV) subtyping schemes
Apache License 2.0
25 stars 7 forks source link

Output 'NA' as subtype when no subtype found #113

Closed glabbe closed 4 years ago

glabbe commented 4 years ago

Hi @peterk87, could you let me know if the changes I made are acceptable to fix the problem highlighted by @dankein in issue#112?

peterk87 commented 4 years ago

The development branch version of biohansel already outputs #N/A for null subtype results (added in PR #81)

See: https://github.com/phac-nml/biohansel/blob/development/bio_hansel/main.py#L248

glabbe commented 4 years ago

Yes you're right @peterk87 , I had not checked it before making the modifications. Will cancel this pull request.