Closed peterk87 closed 4 years ago
Hi @peterk87,
Everything seems to be in order on the code side. Pytests run on both 3.6 and 3.7 as expected.
Although I think I've found an installation issue I missed last time (or I don't know how to install). Currently I pip install from the branch (pip install .
) and when I do that, the aho_corasick and qc directories are not being copied with the data (no issue when I tried 2.3 or 2.2 in this).
I'll see if its on my end a bit more as well
Thanks a lot @DarianHole for taking a look at this PR! I fixed the packaging issue and made the suggested changes.
I think it should auto-deploy when a release tag is created.
The user and secure password could be changed to the phac-nml
and a secure password generated by the travis-ci cli tool. I've added the phac-nml
user as a project owner on PyPI.
@peterk87 I am not authorized to merge this one but its good. Let me know if anything else is needed!
Thanks a lot @DarianHole! I'll create a v2.4.0 release and make sure it's up on PyPI
Thanks a lot @peterk87 and @DarianHole for this new version release, much appreciated!
Change log for v2.4.0 release:
tb_speciation
totb_lineage
(#110)