search

phac-nml / mob-suite

MOB-suite: Software tools for clustering, reconstruction and typing of plasmids from draft assemblies
Apache License 2.0
125 stars 33 forks source link

Add --version switch to all tools #35

Closed tseemann closed 4 years ago

tseemann commented 5 years ago 
% mob_typer --version 2> /dev/null
mob_typer 2.0.2

% echo $?
0

print to stdout and return error code 0

EricDeveaud commented 5 years ago

+1 as you have a mob_suite.version you may want to add something like that

parser.add_argument('--version', action='version', version='%(prog)s {version}'.format(version=version))

ooops sorry did'nt saw it was alredy pull-requested. sorry

tseemann commented 5 years ago

@EricDeveaud - that is the simplest way to do it, thank you!

I don't see a PR or Commit for this yet?

EricDeveaud commented 5 years ago

I don't see a PR or Commit for this yet?

see: https://github.com/phac-nml/mob-suite/pull/37

kbessonov1984 commented 5 years ago

We've added the -V switch in the latest PR and accommodated the taxa.sqlite request to be in databases folder. We are tackling several issues in this PR. I am doing final tests and will release version 2.0.2 in a couple of hours. Thank you for your help.

kbessonov1984 commented 5 years ago

James added -V, --version show program's version number and exit switch in all the tools as requested. Try it out in 2.0.2 release. E.g.

$mob_typer --version
mob_typer (2.0.2)
tseemann commented 5 years ago

Please remove the brackets. That is not GNU standard, and will cause parsing issues in pipeline audits. The example I gave at the top is what it should be.

jrober84 commented 4 years ago

This issue has been resolved in release 2.1.0, thanks for your help @tseemann

tseemann commented 4 years ago

Thank you @jrober84