fix warning: circular argument reference - webhook

phallstrom / slackistrano

Slack integration for Capistrano deployments.

MIT License

374 stars 74 forks source link

fix warning: circular argument reference - webhook #13

Closed nikolai-b closed 9 years ago

nikolai-b commented 9 years ago

On ruby 2.2.0 there is a warning when using this gem, see https://bugs.ruby-lang.org/issues/10314 for background

phallstrom commented 9 years ago

@nikolai-b Thanks. I didn't accept your PR since it never should have been "webhook: webhook" to begin with, but "webhook: nil". I've pushed out 0.1.4 to rubygems. Let me know if you encounter any issues.

nikolai-b commented 9 years ago

ah ok, I was a bit confused as to where webhook was being defined. Makes sense now. Cheers.