set :slack_channel is mandatory for slackbot

phallstrom / slackistrano

Slack integration for Capistrano deployments.

MIT License

374 stars 74 forks source link

set :slack_channel is mandatory for slackbot #24

Closed osaris closed 9 years ago

osaris commented 9 years ago

Hello,

Thanks for this gem, it works perfectly but readme doesn't seems up2date and we need to set slack_channel to get it working using slackbot.

No error is reported if channel isn't set, I had to dig to https://github.com/supremegolf/slackistrano/blob/242890bc7bdb12064250180210087d7dd9c5861a/lib/slackistrano/tasks/slack.rake#L88 to find the cause.

Regards,

Raphaël

phallstrom commented 9 years ago

What would you change in the README? Can you submit a PR with copy updates? Thx!

osaris commented 9 years ago

I'll make a PR but in 2 words, README must say that set :slack_channel is mandatory to get notifications. I first thought that slack_channel is set by default to '#general' (which is ok) and that I can optionally override. It's not optional, it's mandatory ;-)

osaris commented 9 years ago

Proposal in #25

phallstrom commented 9 years ago

Handled in #25.