phallstrom / slackistrano

Slack integration for Capistrano deployments.
MIT License
374 stars 74 forks source link

Bold branch name and stage name (if known) in default Slack messages #28

Closed vassilevsky closed 9 years ago

vassilevsky commented 9 years ago

Hello 👻

I feel that it's important to highlight the most crucial pieces of information in the messages:

It would be strange to embolden an unknown branch though. I offer this solution as the shortest one. I understand that inline rescue is dirty. But there seems to be no potential harm it can do in this context. Nevertheless, please let me know if it needs rewriting.

Thank you.

phallstrom commented 9 years ago

@vassilevsky Nice stuff. Someone else suggested some formatting in #27. I'm inclined to reject both of them if only to prevent it from getting out of hand. Easy enough to override on a case by case basis.

Maybe this is something that should go into the README. A section of various styles with screenshot?

vassilevsky commented 9 years ago

Good point. Accept this and have to accept all that follow until the messages become like sparkling unicorns with drums.

phallstrom commented 9 years ago

:+1: for sparkling unicorns!