search

phallstrom / slackistrano

Slack integration for Capistrano deployments.
MIT License
374 stars 74 forks source link

Logic for Default Webhook Chanel is incorrect #90

Closed arianf closed 5 years ago

arianf commented 5 years ago

https://github.com/phallstrom/slackistrano/blob/00c63ca9927935cbaa518102ae45e88e158029c5/lib/slackistrano/capistrano.rb#L56

If using slack bot is true this will !(true) == false is true, which is the wrong behavior.

Should just be 

if @messaging.via_slackbot? == false && channels.empty?
phallstrom commented 5 years ago

@arianf 3.8.4 is on rubygems. thanks!