search

phanrahan / mantle

mantle library
Other
42 stars 10 forks source link

Lots of depreciation warnings when using magma.circuit.combinational #178

Closed rdaly525 closed 4 years ago

rdaly525 commented 4 years ago

Depreciation warnings look something like:

tests/test_alu.py::test_alu /Users/rdaly/mantle/mantle/primitives/arith.py:6: DeprecationWarning: circuit_generator decorator is deprecated, subclass Generator instead def DeclareAdd(N, cin=False, cout=False):

tests/test_alu.py::test_alu /Users/rdaly/mantle/mantle/primitives/arith.py:50: DeprecationWarning: circuit_generator decorator is deprecated, subclass Generator instead def DeclareSub(N, cin=False, cout=False, T=m.Bits):

tests/test_alu.py::test_alu /Users/rdaly/mantle/mantle/coreir/arith.py:84: DeprecationWarning: circuit_generator decorator is deprecated, subclass Generator instead def DefineAdd(N=None, cout=False, cin=False, width=None, T=m.Bits):

tests/test_alu.py::test_alu /Users/rdaly/mantle/mantle/coreir/arith.py:127: DeprecationWarning: circuit_generator decorator is deprecated, subclass Generator instead def DefineSub(N, cout=False, cin=False, T=m.Bits):

tests/test_alu.py::test_alu /Users/rdaly/mantle/mantle/coreir/LUT.py:10: DeprecationWarning: circuit_generator decorator is deprecated, subclass Generator instead @circuit_generator

rsetaluri commented 4 years ago

Thanks @rdaly525...gonna make a pass to clean it all up

rsetaluri commented 4 years ago

Resolved by #179. Reopen if more warnings pop up