Closed jdemelo closed 3 years ago
Would you mind porting this change over to https://github.com/splunk-soar-connectors/digitalshadows ? The app's been migrated already :)
Would you mind porting this change over to https://github.com/splunk-soar-connectors/digitalshadows ? The app's been migrated already :)
Sure thing!
Hello!
The apps in this repo have been migrated to our new GitHub org https://github.com/splunk-soar-connectors under separate repositories. Kindly re-submit your PR to the repo in the new org for the app you are contributing to.
PAPP-20799: added requirements.txt and wheels
Note:
dsapi
in pypi and GitHub, so I could replace that folder with a wheel.Testing:
ds_api_key
should probably be of data_typepassword
orfile
"data_type": "password"
fords_api_secret_key
. It doesn’t feel like it was an accident to use"data_type": "string"
fords_api_key
right above it/opt/phantom/apps/digitalshadows_8cebdfd7-afe9-48eb-b840-2d98f860ed79/dependencies/
contains at least all the items fromwheels
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
<App Name>: <PR Type> - <PR Description>
next
branch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Release Notes (REQUIRED)
What is the current behavior? (OPTIONAL)
What is the new behavior? (OPTIONAL)
Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)
Thanks for contributing!