phproofpoint: Fix - Fix connectivity test and on_poll actions

x64x76-747126AF333E commented 3 years ago

Fixes for issue #412 causing "Unable to parse JSON response" errors

Please ensure your pull request (PR) adheres to the following guidelines:

Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

[x] Testing of all the changes has been performed (for bug fixes / features)
[x] The readme.html and readme.md have been reviewed and added / updated if needed (for bug fixes / features)
[x] Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
[x] Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
[x] Verify all checks are passing.
[x] Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
[x] Do NOT submit updates to dependencies unless it fixes an issue.
[x] Limit your pull request to one application and submit multiple pull requests if necessary.
Pull Request Type

Please check the type of change your PR introduces:

[ ] New App
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation
[ ] Other (please describe):

Release Notes (REQUIRED)

Fixed issue with Test Connectivity and On Poll actions that caused "Unable to parse JSON response" errors.
Added Python3 compatibility

What is the current behavior? (OPTIONAL)

The _on_poll and _test_connectivity methods of the Proofpoint app currently throw an error ("1 action failed Unable to parse JSON response. Error: Error Message: Expecting value: line 1 column 1 (char 0)")

What is the new behavior? (OPTIONAL)

The _on_poll and _test_connectivity methods of the Proofpoint app will work properly and cause errors.

Other information (OPTIONAL)

Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

Screen Shot 2021-11-02 at 5 18 23 PM

Thanks for contributing!

x64x76-747126AF333E commented 3 years ago

The only failure is Min Phantom Version Test:

 =================================CODE CHECK TESTS=====================================
=====================================================
Check Num of Apps Changed                   | PASS |
=====================================================
Min Phantom Version Test                    | FAIL |
(noncritical, just a warning)
=====================================================
Python Version                              | PASS |
=====================================================
License Usage                               | PASS |
=====================================================
Publisher                                   | PASS |
=====================================================
Verify Password Config                      | PASS |
=====================================================
Description Periods                         | PASS |
=====================================================
Verbose Periods                             | PASS |
=====================================================
Action Names                                | PASS |
=====================================================
Sequential Column Ordering                  | PASS |
=====================================================
Data Path Wildcards                         | PASS |
=====================================================
Check Grammar                               | PASS |
=====================================================
README File                                 | PASS |
=====================================================
Consts File                                 | PASS |
=====================================================
Optional Parameters                         | PASS |
=====================================================

{
    "FAILED": [],
    "PASSED": [
        "Check Num of Apps Changed",
        "Python Version",
        "License Usage",
        "Publisher",
        "Verify Password Config",
        "Description Periods",
        "Verbose Periods",
        "Action Names",
        "Sequential Column Ordering",
        "Data Path Wildcards",
        "Check Grammar",
        "README File",
        "Consts File",
        "Optional Parameters"
    ],
    "WARNINGS": [
        {
            "Min Phantom Version Test": {
                "success": false,
                "message": "Min Phantom version in app json is too low. Found: '4.9.39220' but expected '4.10.0.40961'"
            }
        }
    ]
}

I have tested the updated app code on Phantom version v4.9.39220 and it worked (tested all actions). Is there any way to allow this build to continue?

splunk-soar-connectors-bot commented 3 years ago

Hello!

The apps in this repo have been migrated to our new GitHub org https://github.com/splunk-soar-connectors under separate repositories. Kindly re-submit your PR to the repo in the new org for the app you are contributing to.

phantomcyber / phantom-apps