search

pharo-nosql / mongotalk

A Pharo driver for MongoDB
MIT License
19 stars 13 forks source link

Minor refactoring on existing SCRAMSHA1AuthMechanism #92

Closed rydnr closed 3 years ago

rydnr commented 3 years ago

This is a minor refactoring on existing SCRAMSHA1AuthMechanism. Common logic is moved to a new parent class SCRAMSHAAuthMechanism. Descendant classes SCRAMSHA1AuthMechanism and SCRAMSHA256AuthMechanism only customize the hash function to use.

This PR doesn't implement the handshake mentioned in #87.

tinchodias commented 3 years ago

Thanks for the contribution. It looks good, I will merge it. But it'd be good to add a test using this new authentication method, even if some manual instructions are needed to setup the server. Anyway, I think it's enough for the moment.

tinchodias commented 3 years ago

The CI errors in Pharo 9 are unrelated to this change, and same tests run successfully in Pharo 8.