pharo-spec / Spec

Spec is a framework in Pharo for describing user interfaces.
MIT License
61 stars 63 forks source link

Fix selection bug in SpFilteringSelectableListPresenter #1535

Closed jecisc closed 3 months ago

jecisc commented 3 months ago

SpFilteringSelectableListPresenter has items and a list of the selected items. But if we change the items while a selection exists, we end up with selected elements that are not in the list.

I propose to filter out those selected elements when we update the items. This fixes a bug in the SpChooserPresenter when we could have duplicated elements in the target list if we clicked multiple times on the "move elements" button.

jecisc commented 3 months ago

Failing tests are not related