Refactor IceTipTreeNode to support use of a FormSet

pharo-vcs / iceberg

Iceberg is the main toolset for handling VCS in Pharo.

MIT License

133 stars 84 forks source link

Refactor IceTipTreeNode to support use of a FormSet #1808

Closed Rinzwind closed 6 months ago

Rinzwind commented 7 months ago

This pull request refactors IceTipTreeNode to support use of a FormSet (introduced in Pharo pull request #14998) for the icon and applies that to #repositoryModelsByGroup on IceTipRepositoryModel.

Rinzwind commented 7 months ago

There are two additional commits that I did not include in this pull request: commits a9abd57399489bee and 9fd55052324e1cf4. Commit a9abd57399489bee would change the SpImageTableColumn’s answer for #readObject: from a Form to a FormSet. That would not be a problem for #visitImageColumn: on SpMorphicTableCellBuilder as it just sends the answer #asMorph. But other uses of the SpImageTableColumn could break. I’m guessing that’s at least the case for ‘Spec-Gtk’.