search

phase1geo / Minder

Mind-mapping application for Elementary OS
GNU General Public License v3.0
1.04k stars 67 forks source link

(Flatpak) (Solus Gnome) Issues with rendering window and more #170

Open RTSAjwad opened 4 years ago

RTSAjwad commented 4 years ago

I have the understanding that the flatpak isn't officially maintained after checking this github page. Regardless, I'd like to leave these issues and critiques here incase the maintainer sees it.

  1. When dragging window around the first time, it is fine. Dragging a second time causes app to freeze for a few brief moments.
  2. Going full screen causes the app to display visual glitches and freeze for a few brief moments. This only happens when dragging to the top to full screen. Using maximise/minimise buttons still displays glitches but it is much quicker.
  3. Sidebar animations are slightly delayed.
  4. Expanding sidebar options has no animations.
  5. Resizing sidebar doesn't change cursor. Likewise hovering over text field doesn't change cursor.
  6. I think it should use system gtk theme provided by flatpak. I had to manually set it myself with an environment variable.
  7. I'm guessing this one is to do with the main app itself but importing Freemind files exported from xmind8 doesn't retain the notes.

Apart from this, the app works fine. I'll just full screen it on its own workspace and it's still functional.

phase1geo commented 4 years ago

So #1, #2, #3, #6 are out of my hands.

4 is not supported. Opening the sidebar will not animate the open and closing the sidebar will not animate the close. There is a technical reason for this, but I'd rather not get into it.

5 and #7 are issues that I can and will address with this issue report. In terms of #5, are you referring to the text field in this sidebar? Or are you referring to text within a node in the mind map?

phase1geo commented 4 years ago

Supporting Flatpak currently is not a priority for the project development. Other members of the Flatpak community have put together a Flatpak manifest for the project and have been updating it as we go along; however, I have not received pull requests from those contributors to fix Flatpak-specific issues.

Minder is primarily being developed for elementary OS which, in Hera, requires Debian packaging and sandboxing is not required/enforced. That being said, as elementary OS moves to its next version (6.0 Odin), I believe the goal is to move to Flatpaks wholly. If/when that happens, support for Flatpaks will be given due priority.

phase1geo commented 4 years ago

7 has been taken care of in the devel branch. This will be generally available in the next stable release.

phase1geo commented 4 years ago

Re-reading #6 this evening. I'm curious, what was the environment variable that you used to change the theme?

RTSAjwad commented 4 years ago

Sorry about the late replies. The environment variable was: GTK_THEME=Adwaita So altogether to run the application I use: GTK_THEME=Adwaita flatpak run com.github.phase1geo.minder

This doesn't change the icons however. I think I saw on somebody elses screenshot that they were using yaru theme with the proper icons too but I can't remember. Screenshot from 2020-07-16 12-11-51

RTSAjwad commented 4 years ago

In terms of #5, are you referring to the text field in this sidebar? Or are you referring to text within a node in the mind map?

I was referring to the search bar when you click on the search button from the header bar. Although it doesn't appear for them too. May be a flatpak specific issue. I'm not entirely sure.

RTSAjwad commented 4 years ago

7 has been taken care of in the devel branch. This will be generally available in the next stable release.

Thank you.

RTSAjwad commented 4 years ago

Supporting Flatpak currently is not a priority for the project development. Other members of the Flatpak community have put together a Flatpak manifest for the project and have been updating it as we go along; however, I have not received pull requests from those contributors to fix Flatpak-specific issues.

Minder is primarily being developed for elementary OS which, in Hera, requires Debian packaging and sandboxing is not required/enforced. That being said, as elementary OS moves to its next version (6.0 Odin), I believe the goal is to move to Flatpaks wholly. If/when that happens, support for Flatpaks will be given due priority.

Yes, I understand. I realised after reading through this repository. I didn't really know where I could report the issues so I just put flatpak in my title :/

If a move to flatpaks was to happen in the future then that would be cool. Probably be easier to address non elementary specific issues too. I used to use elementary and it was good :)